pup: enable OAuth for DDSQL editor commands - #756
Draft
srosenthal-dd wants to merge 1 commit into
Draft
Conversation
Remove 3 dsql-editor tool endpoints from OAUTH_EXCLUDED_ENDPOINTS so raw_get/raw_post send the OAuth bearer token for ddsql::spec, ddsql::schema_tables, and ddsql::schema_columns commands. Depends on server-side PR: dd-source#66615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 3 dsql-editor tool endpoints from
OAUTH_EXCLUDED_ENDPOINTSsoraw_get/raw_postsend the OAuth bearer token forddsql::spec,ddsql::schema_tables, andddsql::schema_columnscommands.Server-side dependency
Depends on dd-source#66615 which adds
ValidOAuthAccessTokento the 3 ddsql-editor routes. Do not merge until that PR is merged.Changes
src/raw_client.rs: Removed 3 dsql-editor entries fromOAUTH_EXCLUDED_ENDPOINTS(46 -> 43), updated count test, removed obsolete ddsql-editor test